Skip to content

[Workflow] MarkingStore: remove "arguments" and add "property" #18016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

[Workflow] MarkingStore: remove "arguments" and add "property" #18016

merged 1 commit into from
Mar 21, 2023

Conversation

adpauly
Copy link
Contributor

@adpauly adpauly commented Mar 7, 2023 •
edited
Loading

Node "arguments" being deleted from SF 5.0, I think we could delete it in doc. I selected 6.2 as base but all docs from 5.0 should be updated.
On the contrary, the node "property" is missing.

Sorry if my contribution is clumsy, it is only the second/third. :)

#... 
workflows:
          # Prototype
          name:
              audit_trail:
                  enabled:              false
              type:                 state_machine # One of "workflow"; "state_machine"
              marking_store:
                  # "arguments" does not exist anymore from SF5.0 <-----
                  type:                 ~ # One of "method"
                  property:             marking
                  service:              ~
              supports:             []
              support_strategy:     ~
              initial_marking:      []

              # Select which Transition events should be dispatched for this Workflow
              events_to_dispatch:

                  # Examples:
                  - workflow.enter
                  - workflow.transition
# ...

@OskarStark
Copy link
Contributor

Sorry if my contribution is clumsy, it is only the second/third. :)

Don't worry, so we should merge this in 5.4 branch, right?

@adpauly
Copy link
Contributor Author

adpauly commented Mar 7, 2023 •
edited
Loading

It's deprecated from 4.3 and definitely removed in 5.0.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 21, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 March 21, 2023 14:46
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 21, 2023 14:46
@javiereguiluz
Copy link
Member

@adpauly thanks for fixing this error! We merged this in 5.4, 6.2 and 6.3.

@javiereguiluz javiereguiluz merged commit 9e75d47 into symfony:5.4 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Workflow
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@adpauly @OskarStark @javiereguiluz @carsonbot